[PATCH] D89343: [cmake] Unconditionally set the force flag when codesigning

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 16:44:06 PDT 2020


vsk added a comment.

In D89343#2328892 <https://reviews.llvm.org/D89343#2328892>, @kastiglione wrote:

>> This doesn't require a ld64 version check, and it's a much less invasive cmake change.
>
> Was there consideration about using an arch check, and only doing this for Apple Silicon targets? I think this is fine too, just wanting to cover the bases.

I actually hadn't considered that. We do have `<TARGET_FILE:${name}>`, so we could conceivably derive the target architecture from there and avoid setting force_flag on Intel. I'm not sure the added complexity is warranted though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89343/new/

https://reviews.llvm.org/D89343



More information about the llvm-commits mailing list