[PATCH] D86904: [mlir] Support for defining Types in tblgen

John Demme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 15:00:28 PDT 2020


jdd updated this revision to Diff 297968.
jdd added a comment.

- Rebasing w/ conflicts
- New branch, applying everything at once
- Clang-(format|tidy) fixes
- One more clang-tidy fix
- Changes based on Chris' comments
- Ending a sentence comment w/ a period
- Revisions base on River's comments
- Clang-tidy and some missed comments
- Missed a comment
- clang-format
- Changes based on review
- Remove llvm:: from the cpp file
- Clang-tidy fix
- Another round of changes based on feedback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86904/new/

https://reviews.llvm.org/D86904

Files:
  mlir/cmake/modules/AddMLIR.cmake
  mlir/include/mlir/IR/OpBase.td
  mlir/include/mlir/TableGen/TypeDef.h
  mlir/lib/TableGen/CMakeLists.txt
  mlir/lib/TableGen/TypeDef.cpp
  mlir/test/lib/Dialect/Test/CMakeLists.txt
  mlir/test/lib/Dialect/Test/TestDialect.cpp
  mlir/test/lib/Dialect/Test/TestTypeDefs.td
  mlir/test/lib/Dialect/Test/TestTypes.cpp
  mlir/test/lib/Dialect/Test/TestTypes.h
  mlir/test/mlir-tblgen/testdialect-typedefs.mlir
  mlir/test/mlir-tblgen/typedefs.td
  mlir/tools/mlir-tblgen/CMakeLists.txt
  mlir/tools/mlir-tblgen/OpDocGen.cpp
  mlir/tools/mlir-tblgen/TypeDefGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86904.297968.patch
Type: text/x-patch
Size: 63937 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201013/74813632/attachment.bin>


More information about the llvm-commits mailing list