[PATCH] D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front

Tue Oct 13 09:22:55 PDT 2020

daltenty added a comment.

In D88932#2317202 <https://reviews.llvm.org/D88932#2317202>, @daltenty wrote:

> In D88932#2315531 <https://reviews.llvm.org/D88932#2315531>, @phosek wrote:
>
>> See D70744 <https://reviews.llvm.org/D70744> which is trying to achieve the same, but instead it builds crt together with builtins. When I started working on that change, I also considered the approached used in this change and I briefly discussed it with @beanz, but there was a concern that adding more stages is going to increase already long build time even further.
>
> @phosek Thanks, I think it makes a lot of sense to keep it all together in a single stage. It also avoids duplicating a lot of the config which this approach does. I'm not opposed to abandoning this revision if you'd prefer to revive D70744 <https://reviews.llvm.org/D70744> instead then?

@phosek Gentle ping on whether we are keeping this patch around, or if you'd like to update D70744 <https://reviews.llvm.org/D70744> (since it's already approved) instead. I can merge the approach of D70744 <https://reviews.llvm.org/D70744> into here if you'd prefer to abandon that one instead.

================
Comment at: compiler-rt/cmake/crt-config-ix.cmake:25-41
+set(ARM64 aarch64)
+set(ARM32 arm armhf armv6m armv7m armv7em armv7 armv7s armv7k)
+set(HEXAGON hexagon)
+set(X86 i386)
+set(X86_64 x86_64)
+set(MIPS32 mips mipsel)
+set(MIPS64 mips64 mips64el)
----------------
hubert.reinterpretcast wrote:
> My guess is that the unreferenced lists here are going to become unmaintained lists very quickly. Also, what is the scope associated with these? Are we sure that these are not overriding other definitions before their corresponding use?
These really probably should have a common definition that get's included somewhere. Right now all the various cmake files that need it reproduce the list.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88932/new/

https://reviews.llvm.org/D88932