[PATCH] D89317: [InstructionSimplify] icmp simplification

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/compare.ll:1774
+
+define i1 @icmp_nsw_6(i32 %V) {
+; CHECK-LABEL: @icmp_nsw_6(
----------------
lebedev.ri wrote:
> At least this one is already folded away by instcombine,
> so likely there's some code to be moved/refactored/shared.
> https://godbolt.org/z/Yo3d6h
Yeah, I will look as a follow up. There is some interaction with other passes. I.e., for my motivating code example, this change enables the unroller to fully unroll these type of loops (i.e. loops with an imcp x+y, x+z condition), and then SimplifyCFG can get rid of control-flow. Thus, I need to look if there's overlap and how the passes interact, also with instcombine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89317/new/

https://reviews.llvm.org/D89317