[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok updated this revision to Diff 297794.
alok marked 4 inline comments as done.
alok added a comment.

Incorporated comments from @djtodoro and also removed function re-naming due to pre-built clang-tidy warnings.
Now all other format warning except first are corrected.

-------

/mnt/disks/ssd0/agent/llvm-project/llvm/lib/AsmParser/LLParser.cpp:4599:16: warning: invalid case style for function 'ParseDIGenericSubrange' [readability-identifier-naming]
bool LLParser::ParseDIGenericSubrange(MDNode *&Result, bool IsDistinct) {

  ^~~~~~~~~~~~~~~~~~~~~~
  parseDiGenericSubrange

/mnt/disks/ssd0/agent/llvm-project/llvm/lib/AsmParser/LLParser.cpp:4613:8: warning: invalid case style for variable 'convToMetadata' [readability-identifier-naming]

  auto convToMetadata = [&](MDSignedOrMDField Bound) -> Metadata * {
       ^~~~~~~~~~~~~~
       ConvToMetadata

/mnt/disks/ssd0/agent/llvm-project/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1394:8: warning: invalid case style for variable 'DW_generic_Subrange' [readability-identifier-naming]

  DIE &DW_generic_Subrange =
       ^~~~~~~~~~~~~~~~~~~
       DwGenericSubrange

/mnt/disks/ssd0/agent/llvm-project/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1400:8: warning: invalid case style for variable 'addBoundTypeEntry' [readability-identifier-naming]

  auto addBoundTypeEntry = [&](dwarf::Attribute Attr,
       ^~~~~~~~~~~~~~~~~
       AddBoundTypeEntry

--------


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89218/new/

https://reviews.llvm.org/D89218

Files:
  llvm/include/llvm-c/DebugInfo.h
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/include/llvm/IR/DIBuilder.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/include/llvm/IR/Metadata.def
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.h
  llvm/lib/IR/AsmWriter.cpp
  llvm/lib/IR/DIBuilder.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/IR/LLVMContextImpl.h
  llvm/lib/IR/Verifier.cpp
  llvm/test/Bitcode/generic_subrange.ll
  llvm/test/Bitcode/generic_subrange_count.ll
  llvm/test/DebugInfo/X86/dwarfdump-generic_subrange.ll
  llvm/test/DebugInfo/X86/dwarfdump-generic_subrange_count.ll
  llvm/test/Verifier/digenericsubrange-count-upperBound.ll
  llvm/test/Verifier/digenericsubrange-missing-stride.ll
  llvm/test/Verifier/digenericsubrange-missing-upperBound.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89218.297794.patch
Type: text/x-patch
Size: 41618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201013/b00863eb/attachment-0001.bin>