[PATCH] D89247: [AMDGPU] Add v_fmac_legacy_f32

Tue Oct 13 01:05:23 PDT 2020

foad added a comment.

In D89247#2325783 <https://reviews.llvm.org/D89247#2325783>, @rampitec wrote:

> It also seems to lack changes in SIFoldOperands, SIInstrInfo::FoldImmediate, SIInstrInfo::convertToThreeAddress, SIInstrInfo::canShrink. I think these can go in a separate change.

Right. I'll change the summary to make it clear that this just adds asm/dis support.

================
Comment at: llvm/test/MC/AMDGPU/gfx1030_unsupported.s:1
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1030 -mattr=+WavefrontSize32,-WavefrontSize64 %s 2>&1 | FileCheck --implicit-check-not=error: %s
+// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx1030 -mattr=-WavefrontSize32,+WavefrontSize64 %s 2>&1 | FileCheck --implicit-check-not=error: %s
----------------
arsenm wrote:
> The sutarget features are broken and should be all lowercase
Do you mean they're broken in some other way, as well as not being lowercase?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89247/new/

https://reviews.llvm.org/D89247