[PATCH] D89094: [objdump][macho] Check arch before formating reloc name as arm64 addend

Peng Guo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 22:06:30 PDT 2020


pguo updated this revision to Diff 297764.
pguo added a comment.

Inline the check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89094/new/

https://reviews.llvm.org/D89094

Files:
  llvm/tools/llvm-objdump/MachODump.cpp


Index: llvm/tools/llvm-objdump/MachODump.cpp
===================================================================
--- llvm/tools/llvm-objdump/MachODump.cpp
+++ llvm/tools/llvm-objdump/MachODump.cpp
@@ -453,7 +453,8 @@
   bool isExtern = O->getPlainRelocationExternal(RE);
   uint64_t Val = O->getPlainRelocationSymbolNum(RE);
 
-  if (O->getAnyRelocationType(RE) == MachO::ARM64_RELOC_ADDEND) {
+  if (O->getAnyRelocationType(RE) == MachO::ARM64_RELOC_ADDEND &&
+      (O->getArch() == Triple::aarch64 || O->getArch() == Triple::aarch64_be)) {
     Fmt << format("0x%0" PRIx64, Val);
     return;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89094.297764.patch
Type: text/x-patch
Size: 601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201013/6cfd2b8f/attachment.bin>


More information about the llvm-commits mailing list