[PATCH] D88468: [llvm-readobj] Don't print out section names for STABS symbols

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: llvm/tools/llvm-readobj/MachODumper.cpp:631
+  // indices.
+  if (!(MOSymbol.Type & MachO::N_STAB)) {
+    Expected<section_iterator> SecIOrErr = Symbol.getSection();
----------------
alexshap wrote:
> maybe I'm missing something, but it looks like on the lines 631-639 only the case of non-stab symbols is handled, so for a stab symbol SectionName is set to "",  is there another place where it's updated ? (to cover the "unless we know that .. " part of the comment).
It's not handled. That's what the `TODO` comment is for :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88468/new/

https://reviews.llvm.org/D88468