[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added subscribers: aaron.ballman, lebedev.ri.
jdoerfert added a comment.

Overall this looks sane to me. Don't know who wants to accept this. @rjmccall @lebedev.ri @aaron.ballman @rsmith



================
Comment at: clang/lib/CodeGen/CGCall.cpp:2165
+    assert(getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0 &&
+           "Expected `this` pointer without address space attribute.");
+
----------------
I'm unsure why this assertion has to hold and more importantly why we need it. @arsenm do you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17993/new/

https://reviews.llvm.org/D17993