[PATCH] D89176: Modify split CallSiteRanges to use correct lengths

Di Mo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 12:42:47 PDT 2020


modimo abandoned this revision.
modimo added a comment.

@MaskRay Ah the action table start is inferred as the end of the CST. Saves a pointer but shackles the implementation. These tables will be fairly small (effectively 1 entry per "catch" in a function) and not all CST would need a corresponding action table (only those inside "try" do) so duplicating them is not as far-fetched as it would initially sound.

For my purposes though, the CST entries are guaranteed to be inclusive to the end of the function. Thus, at binary analysis level I can infer the end of the CST from the .eh_frame function length that points me there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89176/new/

https://reviews.llvm.org/D89176



More information about the llvm-commits mailing list