[PATCH] D88928: [Utils] Skip RemoveRedundantDbgInstrs in MergeBlockIntoPredecessor (PR47746)

Mon Oct 12 10:27:03 PDT 2020

vsk added a comment.

In D88928#2324986 <https://reviews.llvm.org/D88928#2324986>, @jmorse wrote:

>> I don't think there's a quick way to check whether a function/basicblock has debug instructions (e.g. you can always inline dbg intrinsics into a function without a !dbg attachment).
>
> (Genuine question:) wouldn't dbg intrinsics be useless without a DISubprogram attached to the Function though, seeing how there wouldn't be a DW_AT_subprogram in the dwarf for variables to be placed in?

Yes, unless the dbg intrinsic is inlined into a function that does have a DISubprogram (and its scope is correctly fixed up).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88928/new/

https://reviews.llvm.org/D88928