[llvm] ad55410 - [LoopDeletion] Remove over-eager SCEV verification.

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 08:19:03 PDT 2020


Author: Florian Hahn
Date: 2020-10-12T16:18:30+01:00
New Revision: ad5541045a63fe3049fc910d843bcbb78f7c7056

URL: https://github.com/llvm/llvm-project/commit/ad5541045a63fe3049fc910d843bcbb78f7c7056
DIFF: https://github.com/llvm/llvm-project/commit/ad5541045a63fe3049fc910d843bcbb78f7c7056.diff

LOG: [LoopDeletion] Remove over-eager SCEV verification.

60b852092c98dbdc6248d60109d90ae6f8ad841c introduced SCEV verification to
deleteDeadLoop, but it appears this check is currently a bit over-eager
and some users of deleteDeadLoop appear to only patch up SE after
calling it (e.g. PR47753).

Remove the extra check for now. We can consider adding it back after we
tracked down the source of the inconsistency for PR47753.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/LoopUtils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/LoopUtils.cpp b/llvm/lib/Transforms/Utils/LoopUtils.cpp
index ccb9b6d0bdb4..d7cd9b19b8d5 100644
--- a/llvm/lib/Transforms/Utils/LoopUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUtils.cpp
@@ -724,11 +724,6 @@ void llvm::deleteDeadLoop(Loop *L, DominatorTree *DT, ScalarEvolution *SE,
     }
     LI->destroy(L);
   }
-
-#ifndef NDEBUG
-  if (SE)
-    SE->verify();
-#endif
 }
 
 /// Checks if \p L has single exit through latch block except possibly


        


More information about the llvm-commits mailing list