[PATCH] D89214: [X86] Add basic computeKnownBits support for X86ISD::BSR

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 08:15:49 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:34045
+    // TODO: Bound with input known bits?
+    Known.Zero.setBitsFrom(Log2_32(BitWidth));
+    break;
----------------
I'm a bit worried about not handling the src==0 undef case - how well does this work if we guarded it with a KnownNeverZero check?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89214/new/

https://reviews.llvm.org/D89214



More information about the llvm-commits mailing list