[PATCH] D88815: Added .tabletype to asm and multiple table support in obj files

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 07:40:23 PDT 2020


pmatos marked 3 inline comments as done.
pmatos added inline comments.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1529
+        // FIX (pmatos): Which limits should by default be imposed to tables?
+        Table.Limits = {wasm::WASM_LIMITS_FLAG_NONE, 0, 0};
+
----------------
sbc100 wrote:
> Presumably the limits should be part of the type eventually?
I agree but I can work on moving the limits in a future patch, if that's fine with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88815/new/

https://reviews.llvm.org/D88815



More information about the llvm-commits mailing list