[PATCH] D89152: [lld][WebAssembly] Add support for -Bsymbolic

Mon Oct 12 07:03:36 PDT 2020

jhenderson added a comment.

In D89152#2324952 <https://reviews.llvm.org/D89152#2324952>, @sbc100 wrote:

> In D89152#2324938 <https://reviews.llvm.org/D89152#2324938>, @sbc100 wrote:
>
>> In D89152#2324369 <https://reviews.llvm.org/D89152#2324369>, @jhenderson wrote:
>>
>>>> sbc100 edited reviewers, ... removed: jhenderson.
>>>
>>> (I've got a herald rule to auto-add myself to reviews touching llvm-readobj amongst other tools - no point trying to work around it!)
>>
>> Sorry, didn't mean to try to work around your herald stuff, I also use herald to be notified about WebAssembly related thing.   I think I was just trying to be precise about who I thought would be good reviewer.   I won't remove your name anymore from that field.
>>
>> In general, would it would make sense to add yourself to subscriber rather than reviewer if you want to monitor all changes in these areas?  You could then add yourself as a reviewer to change that you care about?   Or do you want to actually be a reviewer all of all change to lld?    For example, this specific change, do you want to be a reviewer?
>
> Sorry, I see now that it was probably the fact that I touched objdump here that added you as a reviewer.   My comment is less relevant in that case I guess.

No problem! I'm keen to keep an eye on patches in the LLVM binutils (readelf, objdump etc), mostly for ELF, but I often chip in on other platforms too, in an effort to maintain consistency, make sure documentation is sorted etc. I'm not bothered by LLD (and don't have a herald rule setup for that), though I do sometimes help out with reviews in the ELF part of LLD too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89152/new/

https://reviews.llvm.org/D89152