[PATCH] D89211: [RTDYLD] add debug statements for resolveX86Relocation

Valentin Churavy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 07:00:17 PDT 2020


vchuravy added a comment.

In D89211#2324122 <https://reviews.llvm.org/D89211#2324122>, @MaskRay wrote:

> I think this can be very noisy as the number of relocations can be very large.

I agree. They can be rather noisy, but without them the only tool you have to debug relocations going wrong is to dump the section before and after relocations and to perform a manual diff,
and the code for x86_64 has the same debug statements for some relocations types as well. This kinda makes me wish we had multiple levels of debug output for LLVM, but let's not go there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89211/new/

https://reviews.llvm.org/D89211



More information about the llvm-commits mailing list