[PATCH] D89152: [lld][WebAssembly] Add support for -Bsymbolic

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 06:54:40 PDT 2020


sbc100 added a comment.

In D89152#2324369 <https://reviews.llvm.org/D89152#2324369>, @jhenderson wrote:

>> sbc100 edited reviewers, ... removed: jhenderson.
>
> (I've got a herald rule to auto-add myself to reviews touching llvm-readobj amongst other tools - no point trying to work around it!)

Sorry, didn't mean to try to work around your herald stuff, I also use herald to be notified about WebAssembly related thing.   I think I was just trying to be precise about who I thought would be good reviewer.   I won't remove your name anymore from that field.

In general, would it would make sense to add yourself to subscriber rather than reviewer if you want to monitor all changes in these areas?  You could then add yourself as a reviewer to change that you care about?   Or do you want to actually be a reviewer all of all change to lld?    For example, this specific change, do you want to be a reviewer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89152/new/

https://reviews.llvm.org/D89152



More information about the llvm-commits mailing list