[PATCH] D89142: llvmbuildectomy

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 10 18:47:56 PDT 2020


GMNGeoffrey added a comment.

In D89142#2323331 <https://reviews.llvm.org/D89142#2323331>, @thieta wrote:

> In D89142#2322663 <https://reviews.llvm.org/D89142#2322663>, @mehdi_amini wrote:
>
>> Wow pretty neat to see `llvmbuild` being removed!
>>
>> That said we are still depending on it (we generate Bazel build file from this and use this in many projects using MLIR like TensorFlow, XLA, IREE...).
>> We need to move away from it: can you ping me and/or @GMNGeoffrey when you get closer to have this in a landing state?
>
> Could the generation of Bazel files be done by parsing the compile_commands.json maybe? that seems like a more "portable" approach since it's a pretty standard format these days.

We're working on hand-written Bazel BUILD files at https://github.com/google/llvm-bazel, so the generation from LLVMBuild.txt (or something else) shouldn't be necessary. Of course automatically converting between systems would be nice, but is practically pretty difficult, especially since Bazel tends to track more things than CMake, so inherently CMake doesn't have all the information Bazel needs. Anyway we should be able to shift people over to the new ones, but they're not quite ready yet (in particular working on detecting and setting all the configuration options for various platforms is WIP).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89142/new/

https://reviews.llvm.org/D89142



More information about the llvm-commits mailing list