[PATCH] D89105: [X86] Support Intel avxvnni

[LiuChen via Phabricator via llvm-commits]

LiuChen3 marked an inline comment as done.
LiuChen3 added a comment.





================
Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:46
 #pragma push_macro("AND")
-#define AND(a, b) a "," b
+#define AND(a, b) "(" a "),(" b ")"
 
----------------
RKSimon wrote:
> Pull this out? This and the CodeGenFunction.* changes seem to be worth a separate patch
Thanks for your review.
I will separate this part. I want to keep this part here for now until another patch is merged in.


================
Comment at: clang/lib/Headers/avxvnniintrin.h:31
+
+#include "commonvnniintrin.h"
+
----------------
RKSimon wrote:
> Is having a commonvnniintrin.h header the approach gcc/icc are taking?
GCC doesn't have commonvnniintrin.h headr, they only have avxvnniintrin.h. For ICC, I will check with this and give you answer later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105