[PATCH] D89178: [X86] Alternate implementation of D88194.

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 21:59:31 PDT 2020


xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:858
+          --I;
+          CurDAG->ReplaceAllUsesOfValueWith(SDValue(N, 0), Complement);
+          ++I;
----------------
Can we replace a constant with a reg without checking the operation?
I am afraid it may cause ISEL failed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89178/new/

https://reviews.llvm.org/D89178



More information about the llvm-commits mailing list