[PATCH] D89163: [X86][test] Add a regression test for lock cmpxchg16b on a global variable with offset

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 14:18:09 PDT 2020


craig.topper added a comment.

Thanks for the test.



================
Comment at: llvm/test/CodeGen/X86/atomic128.ll:86
+;; Make sure we retain the offset of the global variable.
+define dso_local void @cmpxchg16b_global_with_offset() #0 {
+; CHECK-LABEL: cmpxchg16b_global_with_offset:
----------------
Drop dso_local and the #0?


================
Comment at: llvm/test/CodeGen/X86/atomic128.ll:90
+; CHECK-NEXT:    pushq %rbx
+; CHECK-NEXT:    .cfi_def_cfa_offset 16
+; CHECK-NEXT:    .cfi_offset %rbx, -16
----------------
Can we add nounwind to drop the cfi directives?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89163/new/

https://reviews.llvm.org/D89163



More information about the llvm-commits mailing list