[PATCH] D89162: [SVE][WIP] Lower fixed length VECREDUCE_SEQ_FADD operation

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 14:00:50 PDT 2020


cameron.mcinally created this revision.
cameron.mcinally added reviewers: paulwalker-arm, kmclaughlin, sdesmalen, efriedma.
Herald added subscribers: llvm-commits, psnobl, hiraditya, kristof.beyls, tschuett.
Herald added a project: LLVM.
cameron.mcinally requested review of this revision.

@paulwalker-arm, I'm guessing this hits the reduction legalisation problems that @kmclaughlin is working on? This patch currently falls apart during splitting of the reduction nodes. If not, I'll continue to build it out.

Some other notes:

1. It looks like NEON FADDA support is missing upstream too.

2. We'll likely need to change how the OperationAction types are determined for the reduction-with-accumulator ISD nodes (see LegalizeDAG.cpp change). The types are currently based off the start_value type, not the vector op type. @sdesmalen


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89162

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/test/CodeGen/AArch64/sve-fixed-length-fp-reduce.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89162.297329.patch
Type: text/x-patch
Size: 14369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201009/42deb36f/attachment.bin>


More information about the llvm-commits mailing list