[PATCH] D88921: [MemCpyOpt] Fix thread-safety of call slot opimization

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Oh, I see, the unmodified callCapturesBefore result is correct if you're trying to determine whether the the call might modify a value that can be consumed by a load, but not if you're trying to determine if a store clobbers memory that might be used in another thread.

I think I'd prefer to sink the conditional into callCapturesBefore itself, so anyone who modifies it in the future has the necessary context.  I think the isa<Argument> check is too tightly coupled to the implementation of callCapturesBefore, as opposed to its abstract semantics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88921/new/

https://reviews.llvm.org/D88921