[PATCH] D89150: [GlobalISel] Remove scalar src from fadd/fmul reductions.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 10:45:00 PDT 2020


aemerson created this revision.
aemerson added reviewers: arsenm, paquette.
aemerson added a project: LLVM.
Herald added subscribers: hiraditya, rovka.
aemerson requested review of this revision.
Herald added a subscriber: wdng.

It's probably better to split these into separate G_FADD/G_FMUL + G_VECREDUCE operations in the translator rather than carrying the scalar around. The majority of the time it'll get simplified away as the scalars are probably identity values.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89150

Files:
  llvm/docs/GlobalISel/GenericOpcode.rst
  llvm/include/llvm/Target/GenericOpcodes.td
  llvm/lib/CodeGen/MachineVerifier.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir
  llvm/test/MachineVerifier/test_vector_reductions.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89150.297280.patch
Type: text/x-patch
Size: 5980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201009/b750de70/attachment.bin>


More information about the llvm-commits mailing list