[PATCH] D89099: [lld][ELF] Rewrite ICF-folded references rather than tombstoning them

Fri Oct 9 09:11:12 PDT 2020

MaskRay added a comment.

We decided to use a tombstone value because multiple CUs with overlapping address ranges and shared entities are problematic (PR47150#comment3).
The main reason we exclude .debug_info is because breaking points do not work on folded functions (D82828 <https://reviews.llvm.org/D82828>).

The patch will revert all ICF related behavior and make us go back to square one (if we do this, I don't see the value of `!isDebug`) and cause confusion to DWARF consumers.
Do we need this? From https://bugs.llvm.org//show_bug.cgi?id=47150#c5 this is a bug in llvm-gsymutil.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89099/new/

https://reviews.llvm.org/D89099