[PATCH] D89039: [yaml2obj/obj2yaml] - Add support of 'Size' and 'Content' keys for all sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 03:55:08 PDT 2020


grimar added a comment.

In D89039#2320874 <https://reviews.llvm.org/D89039#2320874>, @jhenderson wrote:

> Given this change, there's a lot of duplicated code across the various section varieties. There are two common patterns I see:
>
> 1. Writing using the Content/Size and setting the sh_size field accordingly.

Now am am experimienting with this point. At this moment I am pretty sure that the patch I am working on
should be a follow-up for this one, because the approach I am experimenting with assumes that all of sections supports both "Content" and "Size",
what just was not true before this patch.

Let me finish and post a patch, I hope it might convince you that this clean-up is also better to be done on top.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89039/new/

https://reviews.llvm.org/D89039



More information about the llvm-commits mailing list