[PATCH] D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 03:47:19 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

I'm okay to stick with this approach. I don't think it hurts to have such an option, even if we do decide in the future to add a wildcard/regex option. @rupprecht, are you happy?



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:140
+      // When removing all RPaths we don't need to care
+      // about what it contains
+      if (Config.RemoveAllRpaths)
----------------
Nit: comments should end with a full-stop. You've probably also prematurely wrapped this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88674/new/

https://reviews.llvm.org/D88674



More information about the llvm-commits mailing list