[PATCH] D89105: [X86] Support Intel avxvnni

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Please can you add an entry to the 12.0 release notes?



================
Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:46
 #pragma push_macro("AND")
-#define AND(a, b) a "," b
+#define AND(a, b) "(" a "),(" b ")"
 
----------------
Pull this out? This and the CodeGenFunction.* changes seem to be worth a separate patch


================
Comment at: clang/lib/Headers/avxvnniintrin.h:31
+
+#include "commonvnniintrin.h"
+
----------------
Is having a commonvnniintrin.h header the approach gcc/icc are taking?


================
Comment at: clang/lib/Headers/avxvnniintrin.h:39
+static __inline__ __m256i __DEFAULT_FN_ATTRS256
+_mm256_dpbusd_avx_epi32(__m256i __S, __m256i __A, __m256i __B)
+{
----------------
Please can you add doxygen descriptions to each intrinsic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105