[PATCH] D89097: [llvm-readelf/obj][test] - Stop using precompiled binary in mips-plt.test

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 00:37:39 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-plt.test:4-5
+# RUN: yaml2obj --docnum=1 %s -o %t.plt.o
+# RUN: llvm-readobj -A %t.plt.o 2>&1 | FileCheck %s --check-prefix=LLVM
+# RUN: llvm-readelf -A %t.plt.o 2>&1 | \
+# RUN:   FileCheck %s --strict-whitespace --match-full-lines --check-prefix=GNU
----------------
jhenderson wrote:
> What's the point of the `2>&1`? There's no check that there are [no] warnings in the readobj case at least.
You're right. Placed it by mistake, I'll remove.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89097/new/

https://reviews.llvm.org/D89097



More information about the llvm-commits mailing list