[PATCH] D88667: [GlobalISel] Change asserting conditions when initializing call site info

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRParser/MIRParser.cpp:372-373
+    unsigned BlockNum = MILoc.BlockNum;
+    // In case of using GlobalISel, entry block enumeration doesn't start
+    // from 0, but from 1.
+    if (YamlMF.Body.Value.Value.find("bb.0") == std::string::npos)
----------------
I think treating this as some difference to tolerate is the wrong approach. There's no reason the block numbers should change based on the selector


================
Comment at: llvm/test/CodeGen/X86/globalisel-entry-block-enumeration.ll:2-3
+;; Test enumeration of entry basic blocks when using GlobalISel.
+;; When using other instruction selectors entry blocks will start
+;; from 0, in case of GlobalISel they start from 1.
+; RUN: llc -emit-call-site-info -global-isel %s -stop-after=finalize-isel -o %t.mir
----------------
A pure input MIR test in test/CodeGen/MIR would be preferable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88667/new/

https://reviews.llvm.org/D88667