[PATCH] D88561: [llvm-readobj] - Fix possible crashes related to dumping gnu hash symbols.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 00:56:10 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good aside from a possible broken test.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnuhash.test:128
 # SYMNDX-NEXT:   Buckets: [2]
-# SYMNDX-NEXT: warning: '[[FILE]]': unable to dump 'Values' for the SHT_GNU_HASH section: the first hashed symbol index (2) is larger than the number of dynamic symbols (2)
+# SYMNDX-NEXT: warning: '[[FILE]]': unable to dump 'Values' for the SHT_GNU_HASH section: the first hashed symbol index (2) is greater than or equal to the number of dynamic symbols (2)
 # SYMNDX-NEXT: }
----------------
This test looks like it might need updating?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88561/new/

https://reviews.llvm.org/D88561



More information about the llvm-commits mailing list