[PATCH] D88502: [llvm][Support] Delete unused is_absolute_gnu helper

Wed Oct 7 16:26:37 PDT 2020

tinti added a comment.

@

In D88502#2303036 <https://reviews.llvm.org/D88502#2303036>, @kadircet wrote:

> Hi @tinti this code seems to be recently introduced without any usage, and as pointed out by @certl it doesn't consider multi-byte drive letters.

Hi @certl and @kadircet.

It intentionally does not consider multi-byte drive letters because it mimics GNU's objdump (which does not either).

> Are you planning to add any usages to the helper? If so, please consider Christopher's points about potential problems.
> If you are not planning to add any usages, I beleive it would be best to delete the helper to reduce confusion.

Yes I am. I am about to submit another patch for llvm-objdump.

> WDYT?

We considered using LLVM's helpers but would be too much work. It is simpler to do this way.

Please take a look at: https://reviews.llvm.org/D87667

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88502/new/

https://reviews.llvm.org/D88502