[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 15:40:49 PDT 2020


jrtc27 added a comment.

In D88832#2318159 <https://reviews.llvm.org/D88832#2318159>, @Paul-C-Anagnostopoulos wrote:

> So why don't I make the new function take ArrayRef<StringRef> and simply restore the original function to its original form. Then there is no problem with the original function accepting a string literal.
>
> Is that a good solution? Otherwise I really don't know what to do.

That's what I was originally suggesting and then you started saying you had issues with ambiguity when doing a different variant of that, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88832/new/

https://reviews.llvm.org/D88832



More information about the llvm-commits mailing list