[PATCH] D88982: [NFCI] Add PolyBase as base class for ElementCount, TypeSize and StackOffset.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In D88982#2317443 <https://reviews.llvm.org/D88982#2317443>, @ctetreau wrote:

> This isn't really a true polynomial because it doesn't support multiplication of two terms: `2x * 2x = 4x^2`
>
> If what we have here is all we need, then I think it's fine (having not actually code reviewed the implementation at the time of this writing), but we should call it like it is, and ideally implement it in such a way that it would be straightforward to implement a true polynomial.

Are you suggesting rename PolyBase or just to remove the term 'polynomial' from the commit message and any of the comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88982/new/

https://reviews.llvm.org/D88982