[PATCH] D87490: [MachineInstr] return mayAlias for not mayLoadOrStore instructions.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 07:30:13 PDT 2020


lebedev.ri added a comment.

In D87490#2316705 <https://reviews.llvm.org/D87490#2316705>, @shchenz wrote:

> In D87490#2316034 <https://reviews.llvm.org/D87490#2316034>, @lebedev.ri wrote:
>
>> For starters, this is missing a test.
>
> @lebedev.ri thanks for looking into this, Roman. This patch protects protential alias query between a call instruction and a call/load/store instruction. Currently there is no such query in clang/llvm code base. So if we don't add a problematic alias query first in clang/llvm code base, there will be no difference with/without this patch. So I leave this without a test. Hope this is ok.

So why are we adding dead code then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87490/new/

https://reviews.llvm.org/D87490



More information about the llvm-commits mailing list