[PATCH] D71126: Adding PoisonValue for representing poison value explicitly in IR

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 03:32:32 PDT 2020


aqjune added a comment.

In D71126#2316089 <https://reviews.llvm.org/D71126#2316089>, @nikic wrote:

> I would recommend making PoisonValue a subclass of UndefValue. Poison can always be relaxed to undef, and this will prevents lots of regressions when replacing undef with poison values.

+1 for this. You'll need to update `UndefValue::classof`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71126/new/

https://reviews.llvm.org/D71126



More information about the llvm-commits mailing list