[PATCH] D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test.

[Luqman Aden via Phabricator via llvm-commits]

luqmana marked an inline comment as done.
luqmana added a comment.

In D88635#2316128 <https://reviews.llvm.org/D88635#2316128>, @grimar wrote:

> I think you can:
>
> 1. Merge 7 test cases you have into one (use yaml2obj's `--docnum` option, see examples in `llvm-readobj\ELF\`)
> 2. Perhaps you can reuse YAMLs with use of yaml2obj's macros feature (-D<macro>=<value>). See `llvm-readobj\ELF\reloc-addends.test` and many other tests.
> 3. It feels that you should be able to reduce YAML descriptions, e.g. remove excessive sections? (so, try to keep parts that are related/needed only)

Done but I just left the 32bit and 64bit yaml separate as I don't think it's worth combining them. But I did get it down to just 3 docs overall. Also removed a lot of the stuff unnecessary for the tests. They won't run now but that's not important for the test I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88635/new/

https://reviews.llvm.org/D88635