[PATCH] D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 16:41:11 PDT 2020


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-blockaddress.ll:28
+  ret void
+; CHECK:         .section .text,"ax", at progbits,unique,2
+; CHECK-NEXT:    .Ltmp1:
----------------
snehasish wrote:
> I think you meant to only indent the instructions, the labels should be indented less here and above?
The excess indentation is here to satisfy the longest directive CHECK-LABEL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88517/new/

https://reviews.llvm.org/D88517



More information about the llvm-commits mailing list