[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Tue Oct 6 14:56:01 PDT 2020

hans added a comment.

In D84380#2315093 <https://reviews.llvm.org/D84380#2315093>, @amccarth wrote:

> In D84380#2314645 <https://reviews.llvm.org/D84380#2314645>, @hans wrote:
>
>> It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).
>
> It's confusing me why builds should be so sensitive to the user's environment.  Sometimes what you want or need in your shell is different than what the build needs.

If the build runs in the shell it seems natural to me that it should depend on the shell environment.

> We essentially have an high dimensional matrix of build configurations, which is completely unsupportable.  This change was a step in the right direction in that it lopped off one of the countless dimensions where things could go wrong by making it easy to use current, supported tools.

To me this seems to have added an extra dimension. Previously, lit would look for the tools on PATH, now it was made to look in two places.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380