[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 08:54:38 PDT 2020


hans added a comment.

It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).

Can't folks who want to use the git tools put them on their PATH?

After this patch I think it's surprising to users why the git tools are used when e.g. the gnuwin tools are the only ones available on PATH.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380



More information about the llvm-commits mailing list