[PATCH] D85024: [llvm-objdump] Implement --prefix option

Tue Oct 6 04:48:37 PDT 2020

jhenderson added a comment.

In D85024#2313357 <https://reviews.llvm.org/D85024#2313357>, @tinti wrote:

> Hi @jhenderson,
>
> I believe I should create more tests addressing:
>
> - On Windows trailing '\' should be removed.
> - On Posix trailing '\' should be kept.
>
> As far as I know I would need to duplicate  `source-interleave-absolute-paths.test` and add REQUIRES: x (or UNSUPPORTED: x).
>
> Is there a better way of doing it?

I believe where there's a difference in behaviour based on the OS, you should have two separate tests, which use REQUIRES and UNSUPPORTED accordingly. I'm not aware of a way within a single test to customise what is checked for otherwise.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024