[PATCH] D88835: [llvm-readelf] - Implement --addrsig option.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Thanks for review! I'll hold this a bit to see if @jhenderson is also happy with the output format etc.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4775
+  for (uint64_t Sym : *SymsOrErr) {
+    Fields[0].Str = to_string(format_decimal(++SymIndex, 6)) + ":";
+    Fields[1].Str = this->dumper().getStaticSymbolName(Sym);
----------------
MaskRay wrote:
> Can Twine be leveraged to avoid the temporary std::string construction?
`format_decimal` returns `FormattedNumber`, it can't be use to construct a `Twine`, so seems we can't save anything here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88835/new/

https://reviews.llvm.org/D88835