[PATCH] D88772: [X86] .code16: temporarily set Mode32Bit when matching an instruction with the data32 prefix

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 17:49:05 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3092
+      // TODO Generalize.
+      if (Next == "callw")
+        Next = "calll";
----------------
craig.topper wrote:
> So unlike the previous code we're allowing plain "call" to be selected based on the forced mode?
Now we match `data32 something` as one instruction instead of two.

The "call" special case can be dropped. Generalizing the suffix replacement is tricky and requires a think about the `"bwlq"` suffix rules on 3842.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88772/new/

https://reviews.llvm.org/D88772



More information about the llvm-commits mailing list