[PATCH] D88853: [X86] Remove X86ISD::LCMPXCHG8_SAVE_EBX_DAG and LCMPXCHG8B_SAVE_EBX pseudo instruction

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 14:37:42 PDT 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

We might need to bring this back if one day we ever chose to use EBX as the base pointer, as MSVC does in 32-bit. We might choose to do that for better compatibility with MSVC inline asm, but we've gotten this far without needing it, and 32-bit becomes less relevant every month.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88853/new/

https://reviews.llvm.org/D88853



More information about the llvm-commits mailing list