[PATCH] D88842: [InstCombine] inttoptr(load) -> load

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 12:03:28 PDT 2020


jdoerfert added a comment.

In D88842#2312459 <https://reviews.llvm.org/D88842#2312459>, @lebedev.ri wrote:

> In D88842#2312448 <https://reviews.llvm.org/D88842#2312448>, @efriedma wrote:
>
>> Not sure what the isUnordered() check is doing.
>
> This is the restriction on `combineLoadToOperationType()`.
> Can we do this unconditionally?

I think we should not do this for atomic operations if the bitwidth is potentially different. That said, I don't see an immediate reason for the type to make an impact otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88842/new/

https://reviews.llvm.org/D88842



More information about the llvm-commits mailing list