[PATCH] D84682: [VPlan] Use VPValue def for VPWidenSelectRecipe.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 11:29:22 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:869
+
+  SelectInst *getUnderlyingInstruction() {
+    return cast<SelectInst>(getUnderlyingValue());
----------------
dmgreen wrote:
> Add a const version too?
I moved getUnderlyingInstr() up to VPRecipeBase , which is using `toVPValue` and updated the code here to use it, as you suggested at a different review IIRC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84682/new/

https://reviews.llvm.org/D84682



More information about the llvm-commits mailing list