[PATCH] D88802: [LLD] [COFF] Add a private option for setting the os version separately from subsystem version

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/COFF/Driver.cpp:412
       break;
-    case OPT_subsystem:
+    case OPT_subsystem: {
+      bool gotVersion = false;
----------------
Setting /subsystem from .drectve is interesting. I guess we added in D39972 (2017). The subsystem can set the entry point, I believe, which can then influence which objects are loaded.

I guess this change doesn't add any new complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88802/new/

https://reviews.llvm.org/D88802