[PATCH] D88382: [VPlan] Turn VPReductionRecipe into a VPValue

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 08:40:35 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:832
                               VPSlotTracker &SlotTracker) const {
-  O << "\"REDUCE of" << *I << " as ";
-  ChainOp->printAsOperand(O, SlotTracker);
+  O << "\"REDUCE of" << *getUnderlyingValue() << " as ";
+  getChainOp()->printAsOperand(O, SlotTracker);
----------------
now that this is a VPValue we should probably just reference the VPValue name using `printAsOperand()`, which will use the underlying value if available.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88382/new/

https://reviews.llvm.org/D88382



More information about the llvm-commits mailing list