[PATCH] D88707: [SVE] Lower fixed length VECREDUCE_AND operation

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 04:56:52 PDT 2020


paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-log-reduce.ll:67
+; VBITS_GE_512-NEXT: fmov w0, s[[REDUCE]]
+; VBITS_GE_512-NEXT: ret
+  %op = load <64 x i8>, <64 x i8>* %a
----------------
Can you add VBITS_EQ_256 check lines to the VBITS_GE_512 related tests to ensure sensible type legalisation. See sve-fixed-length-int-minmax.ll for example.  It looks like I missed this for the other reduction tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88707/new/

https://reviews.llvm.org/D88707



More information about the llvm-commits mailing list