[PATCH] D88821: Fix reordering of instructions during VirtRegRewriter unbundling

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 04:17:12 PDT 2020


critson created this revision.
critson added reviewers: rampitec, foad, arsenm, kerbowa, qcolombet.
Herald added subscribers: llvm-commits, hiraditya, nhaehnle, jvesely.
Herald added a project: LLVM.
critson requested review of this revision.
Herald added a subscriber: wdng.

When unbundling COPY bundles in VirtRegRewriter the start of the
bundle is not correctly referenced in the unbundling loop.

The effect of this is that unbundled instructions are sometimes
inserted out-of-order, particular in cases where multiple
reordering have been applied to avoid clobbering dependencies.
The resulting instruction sequence clobbers dependencies.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88821

Files:
  llvm/lib/CodeGen/VirtRegMap.cpp
  llvm/test/CodeGen/AMDGPU/splitkit-copy-bundle.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88821.296149.patch
Type: text/x-patch
Size: 11136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201005/b389a789/attachment.bin>


More information about the llvm-commits mailing list